London | 26-ITP-JAN | Kayanat Suleman | Sprint 1 | Wireframe#1087
Open
KayanatSuleman wants to merge 14 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-JAN | Kayanat Suleman | Sprint 1 | Wireframe#1087KayanatSuleman wants to merge 14 commits intoCodeYourFuture:mainfrom
KayanatSuleman wants to merge 14 commits intoCodeYourFuture:mainfrom
Conversation
…house score of 100
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
KayanatSuleman
added
Needs Review
MorganDavid
reviewed
Jan 31, 2026
MorganDavid
added
Reviewed
…ted structure of my current index.html page for better webpage structure
KayanatSuleman
added
Needs Review
Author
|
Hi @MorganDavid @cjyuan I have updated the script with the necessary changed. Please review! Thank you. |
Contributor
|
@KayanatSuleman Not sure what you summoned me here. I took a quick look at the deployed page, and here's what I would suggest:
|
Author
|
Hi @cjyuan apologies, I thought since you reviewed my last PR and the deadline is fast approaching I would be able to complete this faster if you were able to review and move it to complete . Thank you I have made the changes. |
Contributor
|
With your recent commit, the footer is no longer fixed at the bottom of the viewport. Can you add CSS code to address this requirement? |
cjyuan
removed
the
Needs Review
cjyuan
added
the
Reviewed
Author
|
Hi @cjyuan thank you for the review - I have now updated the style.css with a fixed footer. Kindest regards - Kay |
Contributor
|
LGTM. Well done. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
header,main,section,article,footer)Questions
None so far, happy to amend. Thank you for reviewing.